build(deps-dev): bump jsdom from 29.0.2 to 29.1.1#222
Conversation
julianken-bot
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Verification ledger (this turn):
gh pr diff 222— change is scoped topackage.json+pnpm-lock.yaml; no source files modified.git log origin/main..pr-head— single Dependabot commitc54e92a; no rebase/squash surprises.gh pr checks 222— all 11 verdict-affecting checks pass (Vitest, ESLint, TypeScript, Next.js Build, 4× E2E, Analyze Bundle, CodeQL).pnpm install --frozen-lockfile— clean against bumped lockfile;+13 -1packages, explained by jsdom's transitive@asamuzakjp/dom-selector 7.0.10→7.1.1and cascading postcss/parse5/entities/tldts bumps.pnpm vitest run(local, on PR head) — 322/322 tests pass under jsdom 29.1.1, including the MermaidDiagram dialog tests that mockshowModal/close(the upstream changes are computed-style fixes — none of the unimplemented APIs the test suite stubs are affected).- npm registry —
jsdom@29.1.1exists and is published; engines^20.19.0 || ^22.13.0 || >=24.0.0are compatible with repoengines.node: >=22provided CI's Node is on a>=22.13minor (Vitest job already proves this).
Findings: none.
Bottom line: stock devDependency minor bump (29.0.2 → 29.1.1). Test environment exclusively — jsdom is only referenced from vitest.config.ts and unit tests, never bundled. Release notes are computed-style fixes + a perf optimization, none of which interact with the project's mocked APIs. Safe to queue.
— @julianken-bot (opus, fresh context)
|
@Mergifyio queue |
Merge Queue Status🛑 Queue command has been cancelled |
Bumps [jsdom](https://github.com/jsdom/jsdom) from 29.0.2 to 29.1.1. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.0.2...v29.1.1) --- updated-dependencies: - dependency-name: jsdom dependency-version: 29.1.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
c54e92a to
c02036d
Compare
julianken-bot
left a comment
There was a problem hiding this comment.
Verdict: APPROVE (re-review on post-fix HEAD)
Verification ledger (this turn, on fd10f22):
gh pr diff 222+git log origin/main..pr222-head— two commits: Dependabot's jsdom bump (c02036d) plus Julian's lockfile fix (fd10f22). Fix commit is 3 lines inpnpm-lock.yaml— re-writes thenext-view-transitionspatch hash from the 64-char hex format Dependabot's pnpm produced to the 26-char base32 format thatpnpm@9.15.9emits.git show origin/main:pnpm-lock.yaml— the new hashnxvyby6r4isjnouuw656h2bwdiis byte-identical to whatorigin/mainalready carries. The fix doesn't invent a hash; it regenerates the one main expects, which is whatpnpm install --frozen-lockfilerequires.pnpm install --frozen-lockfileonfd10f22with localpnpm@9.15.9— clean install, no lockfile mismatch,next-view-transitions.patchapplies.pnpm vitest runonfd10f22— 584/584 tests pass in 6.83s under jsdom 29.1.1. The jsdom changes are computed-style fixes forborder-radius/background-origin/background-clipand agetComputedStyle()perf optimization; the project's unit tests don't assert on those properties.gh pr checks 222— all 11 verdict-affecting checks green onfd10f22(Vitest, ESLint, TypeScript, Next.js Build, 4× E2E, Analyze Bundle, CodeQL, CodeQL Analysis).- Confirmed via
gh pr view --json reviewsthat the prior bot APPROVE onc54e92ais now DISMISSED, as expected once a new commit landed.
Findings: none.
Bottom line: the dismissed-approval signal is mechanically explained by the new commit landing; the new commit itself is a 3-line lockfile regeneration that produces the exact hash main is already using. devDependency-only change (jsdom is referenced from vitest.config.ts and unit tests, never bundled). Safe to re-queue.
— @julianken-bot (opus, fresh context)
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 3 minutes 28 seconds in the queue, including 2 minutes 54 seconds running CI. Required conditions to merge
|
Bumps jsdom from 29.0.2 to 29.1.1.
Release notes
Sourced from jsdom's releases.
Commits
9b9ea7e29.1.107efb78Optimize computed style comparison5f66329Fix background-origin/background-clip in background shorthandad8af77Fix border shorthand handling5a3e88e29.1.073db204Update dependencies and dev dependenciesa7168a5Support ratio CSS unit type15346e0Fix style cache invalidation